Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gettext: Ensure positions always sort #10503

Merged
merged 3 commits into from Jun 1, 2022
Merged

gettext: Ensure positions always sort #10503

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bca9e48
Ensure positions always sort
AA-Turner May 31, 2022
34a8296
Add a warning
AA-Turner May 31, 2022
a1ecf99
Remove warning
AA-Turner Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion sphinx/builders/gettext.py
View file
Open in desktop
Expand Up @@ -53,7 +53,10 @@ def add(self, msg: str, origin: Union[Element, "MsgOrigin"]) -> None:
if msg not in self.metadata: # faster lookup in hash
self.messages.append(msg)
self.metadata[msg] = []
self.metadata[msg].append((origin.source, origin.line, origin.uid)) # type: ignore
line = origin.line
if line is None:
line = -1
self.metadata[msg].append((origin.source, line, origin.uid)) # type: ignore

def __iter__(self) -> Generator[Message, None, None]:
for message in self.messages:
Expand Down