Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ifconfig: Add a meta node to fix iteration #10502

Merged
merged 4 commits into from Jun 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion sphinx/ext/ifconfig.py
Expand Up @@ -51,7 +51,7 @@ def process_ifconfig_nodes(app: Sphinx, doctree: nodes.document, docname: str) -
ns = {confval.name: confval.value for confval in app.config}
ns.update(app.config.__dict__.copy())
ns['builder'] = app.builder.name
for node in doctree.findall(ifconfig):
for node in list(doctree.findall(ifconfig)):
try:
res = eval(node['expr'], ns)
except Exception as err:
Expand Down
1 change: 1 addition & 0 deletions tests/roots/test-ext-ifconfig/conf.py
Expand Up @@ -7,3 +7,4 @@
def setup(app):
app.add_config_value('confval1', False, None)
app.add_config_value('confval2', False, None)
app.add_config_value('false_config', False, None)
10 changes: 10 additions & 0 deletions tests/roots/test-ext-ifconfig/index.rst
Expand Up @@ -9,3 +9,13 @@ ifconfig

egg

Issue 10496 regression test
===========================

.. ifconfig:: false_config

`Link 1 <https://link1.example>`__

.. ifconfig:: false_config

`Link 2 <https://link2.example>`__