Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce body_min_width in basic theme #10197

Merged
merged 4 commits into from May 7, 2022
Merged

Reduce body_min_width in basic theme #10197

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
637cbf5
Reduce `body_min_width` in basic theme
palewire Feb 15, 2022
a48e811
Merge branch '5.x' into patch-1
tk0miya May 7, 2022
eee6be6
html theme: Change the default body_min_width to 360px
tk0miya May 7, 2022
d7af818
Update CHANGES for PR #10197
tk0miya May 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion sphinx/themes/basic/theme.conf
View file
Open in desktop
Expand Up @@ -7,7 +7,7 @@ sidebars = localtoc.html, relations.html, sourcelink.html, searchbox.html
[options]
nosidebar = false
sidebarwidth = 230
body_min_width = 450
body_min_width = 300
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is any reason to choose this value?

I just searched the screensizes of well-used mobile devices. Some reports says 360px is smallest size at present.
https://www.browserstack.com/guide/ideal-screen-sizes-for-responsive-design
https://mediag.com/blog/popular-screen-resolutions-designing-for-all/

Copy link
Contributor Author

@palewire palewire Apr 30, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I picked it because it solved the bug. Another value could work fine if it also resolve the issue.

body_max_width = 800
navigation_with_keys = False
enable_search_shortcuts = True
Expand Down