Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close #9456: html search: Add a config variable; html_show_search_summary #10108

Merged
merged 1 commit into from Jan 17, 2022
Merged

Close #9456: html search: Add a config variable; html_show_search_summary #10108

merged 1 commit into from Jan 17, 2022

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Jan 16, 2022

@tk0miya tk0miya added type:proposal a feature suggestion html search labels Jan 16, 2022
@tk0miya tk0miya added this to the 4.5.0 milestone Jan 16, 2022
@tk0miya tk0miya merged commit 2be0630 into sphinx-doc:4.x Jan 17, 2022
@tk0miya tk0miya deleted the 9456_html_show_search_summary branch January 17, 2022 17:24
Meem514
Meem514 reviewed Jan 26, 2022
View reviewed changes
Copy link

@Meem514 Meem514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you fail when it's a mock?

@tk0miya
Copy link
Member Author

tk0miya commented Jan 27, 2022

What do you mean?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Meem514 Meem514 Meem514 left review comments

Assignees
No one assigned
Labels
html search type:proposal a feature suggestion
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tk0miya @Meem514