Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.3.0 release plan #9824

Closed
tk0miya opened this issue Nov 7, 2021 · 15 comments
Closed

4.3.0 release plan #9824

tk0miya opened this issue Nov 7, 2021 · 15 comments
Assignees
Milestone

Comments

@tk0miya
Copy link
Member

tk0miya commented Nov 7, 2021

Hi maintainers,

About 2months has passed since the last stable release. Based on our release cycle, I'll ship a new package 4.3.0 in nearly days. Do you have any concerns?

  • Initially, the release was planned in this weekend. But I did not have time to work for the release and could not post this release plan this week. So I'd like to postpone it for a few days.

Note: issues marked as 4.3.0:
https://github.com/sphinx-doc/sphinx/milestone/114

@tk0miya tk0miya added this to the 4.3.0 milestone Nov 7, 2021
@jmckenna
Copy link

jmckenna commented Nov 7, 2021

sounds good, thanks @tk0miya-san

@jakobandersen
Copy link
Contributor

No concerns from my side.

@shimizukawa
Copy link
Member

LGTM!

@jakobandersen
Copy link
Contributor

No concerns from my side.

Well, that didn't last long: a variation of #9833 should probably go into 4.x before release.

@tk0miya
Copy link
Member Author

tk0miya commented Nov 9, 2021

I will ship a new version after #9833 will be merged. Maybe within 24 hours.

@tk0miya
Copy link
Member Author

tk0miya commented Nov 10, 2021

Just released! Thank you for all your work!

@tk0miya tk0miya closed this as completed Nov 10, 2021
@jmckenna
Copy link

@tk0miya for your release steps, can you also add:

thanks!

@tk0miya
Copy link
Member Author

tk0miya commented Nov 11, 2021

@jmckenna Could you explain (or give me a pointer) the advantage of the GitHub releases? TBH, I'd not like to increase tasks on releasing...

@hugovk
Copy link
Contributor

hugovk commented Nov 11, 2021

One advantage is people can watch repos for releases only, so they'll get a notification when there's a new release:

image

It doesn't ping for new tags.

I don't have experience myself, but there are some GitHub Actions out there to automatically create a release for tags.

@tk0miya
Copy link
Member Author

tk0miya commented Nov 11, 2021

It would be nice if GHA automatically generates a release on tagging :-)

@tk0miya
Copy link
Member Author

tk0miya commented Nov 11, 2021

@tk0miya
Copy link
Member Author

tk0miya commented Nov 11, 2021

It's helpful if somebody posts a PR :-)

@jmckenna
Copy link

@tk0miya if you click that button that I said earlier, a new tag is auto-generated for the release, and the archives are auto-generated for the release, all you have to do is paste the text: "Sphinx 4.3.0 release is now available, as a bug-fix release. Please see the changelog at https://www.sphinx-doc.org/en/master/changes.html Thank-you to the whole community." <--and the 130+ "watchers" for this repository are auto-magically notified.

@hugovk
Copy link
Contributor

hugovk commented Nov 12, 2021

Please see PR #9842.

https://github.com/actions/create-release is archived, so of the ones linked from there, this uses the one with the most stars: https://github.com/softprops/action-gh-release

@tk0miya
Copy link
Member Author

tk0miya commented Nov 16, 2021

I merged #9842 now. Please wait for the next release.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants