New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sphinx 4.3 will include a breaking change for autodoc_pydantic #62
Comments
I suggest either requiring Sphinx 4.3 as a minimum version, or based on the Sphinx version return either a string or a list of nodes. |
@Yoshanuikabundi Thanks for reporting the issue here and creating sphinx-doc/sphinx#9832. I will take care to make @jakobandersen Thanks for providing the mitigation in the meanwhile. |
@all-contributors please add @Yoshanuikabundi for test |
I've put up a pull request to add @Yoshanuikabundi! 🎉 |
@all-contributors please add @jakobandersen for code |
I've put up a pull request to add @jakobandersen! 🎉 |
@jakobandersen and @Yoshanuikabundi compatibility issues with sphinx 4.3 have been fixed and will be available in in the upcoming release v.1.5.1. |
Hi! I've been lending a hand to contributing to Sphinx itself and discovered that my project no longer built on the upcoming release's branch. I bisected and reported this issue as sphinx-doc/sphinx#9832 and the wonderful Jakob Andersen has tracked the problem down to a change in signature for
get_signature_prefix
(https://www.sphinx-doc.org/en/master/changes.html#id2), which is apparently overwritten by autodoc_pydantic.His comment is here: sphinx-doc/sphinx#9832 (comment)
He's written a mitigation but the behaviour will still be broken, just with a clearer error message. The release is expected to come out in the next few days. Thought you'd want a heads up!
The text was updated successfully, but these errors were encountered: