Sometimes _viewcode_modules can be False; don't crash when it is #8888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not really sure why the tests failed, but it doesn't seem related to this (though it may be?). I'm not familiar enough with the sphinx codebase to determine why and I don't really want to be familiar enough. :-D |
|
Tests are failing due to Pygments 2.8.0 which was released yesterday too, it requires changes to our test suite (cf #8887). |
This was referenced Feb 15, 2021
tk0miya
added a commit
that referenced
this pull request
Feb 15, 2021
|
Thank you for your contribution. Merged into 3.5.x branch now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: Sometimes _viewcode_modules can be False; don't crash when it is
Not sure if this is a 'good' fix for the problem, but my documentation builds now. It appears that when
ModuleAnalyzer.for_module(modname)fails at viewcode.py:90 then it sets the module to False, thus breaking when env_purge_doc is called.Not sure what the ModuleAnalyzer does or why it failed, but I don't care? Would be great to get this out in a 3.5.1 release as soon as possible since this breaks existing documentation.
Feature or Bugfix
Purpose
Detail
Relates