Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intersphinx could fetch remote inventories concurrently #6818

Closed
Zac-HD opened this issue Nov 14, 2019 · 1 comment
Closed

Intersphinx could fetch remote inventories concurrently #6818

Zac-HD opened this issue Nov 14, 2019 · 1 comment
Labels
extensions good first issue type:enhancement enhance or introduce a new feature
Milestone

Comments

@Zac-HD
Copy link
Contributor

Zac-HD commented Nov 14, 2019

Hypothesis has optional integrations with many other libraries, and our intersphinx config currently links to six other sets of documentation. This works beautifully, and we all really appreciate Sphinx! ❤️

However, when the cache is cold or doing a clean build, fetching all of these inventories can take considerably longer than the rest of the build. I propose to use a concurrent.futures thread pool to run the inner loop in load_mappings() when there is more than one inventory that needs to be fetched.

This could give slightly better or slightly worse performance for all-local inventories, but will be much faster for remote inventories. I am happy to open a PR with this change.

@Zac-HD Zac-HD added the type:enhancement enhance or introduce a new feature label Nov 14, 2019
@tk0miya tk0miya added this to the 3.0.0 milestone Nov 14, 2019
@tk0miya
Copy link
Member

tk0miya commented Nov 14, 2019

+1; reasonable. PRs are always welcome!

@tk0miya tk0miya closed this as completed Nov 15, 2019
@tk0miya tk0miya modified the milestones: 3.0.0, 2.3.0 Nov 15, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions good first issue type:enhancement enhance or introduce a new feature
Projects
None yet
Development

No branches or pull requests

2 participants