Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field list rendering style with HTML5 writer #6604

Closed
jakobandersen opened this issue Jul 25, 2019 · 0 comments
Closed

Field list rendering style with HTML5 writer #6604

jakobandersen opened this issue Jul 25, 2019 · 0 comments

Comments

@jakobandersen
Copy link
Contributor

Describe the bug
#6262 mentioned a problem in the Bizstyle theme, but it seems to apply to all themes as 12e6506 introduced the extra CSS in the basic theme. I think the fix #6266, or a variation, should be applied in the basic theme instead, though my CSS knowledge is rather limited.

To Reproduce
Use the archive in #6266 with different themes (e.g., classic) and Sphinx 1.8 and master. The tabular rendering of fields is fine with 1.8, but broken with master (except in the Bizstyle theme).

jakobandersen added a commit to jakobandersen/sphinx that referenced this issue Aug 2, 2019
- classic: Put the pink'ish colour back on the field type part (dt).
- basic: remove top margin on the field data to align with the type.
- basic: use grid display instead of flexbox to avoid fixed width on
  the field type part.

Other themes affected/fixed due to changes in basic:
- bizstyle (only technically, it already was fixed in
  sphinx-doc#6262)
- nature
- sphinxdoc

Fixes sphinx-doc#6604
jakobandersen added a commit to jakobandersen/sphinx that referenced this issue Aug 2, 2019
- classic: Put the pink'ish colour back on the field type part (dt).
- basic: remove top margin on the field data to align with the type.
- basic: use grid display instead of flexbox to avoid fixed width on
  the field type part.

Other themes affected/fixed due to changes in basic:
- bizstyle (only technically, it already was fixed in
  sphinx-doc#6262)
- haiku
- classic
- nature
- pyramid
- sphinxdoc

Fixes sphinx-doc#6604
jakobandersen added a commit to jakobandersen/sphinx that referenced this issue Aug 18, 2019
- classic: Put the pink'ish colour back on the field type part (dt).
- basic: remove top margin on the field data to align with the type.
- basic: use grid display instead of flexbox to avoid fixed width on
  the field type part.

Other themes affected/fixed due to changes in basic:
- bizstyle (only technically, it already was fixed in
  sphinx-doc#6262)
- haiku
- classic
- nature
- pyramid
- sphinxdoc

Fixes sphinx-doc#6604
@tk0miya tk0miya added this to the 2.2.0 milestone Aug 18, 2019
@tk0miya tk0miya closed this as completed Aug 18, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants