New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce body_min_width
in basic theme
#10197
Conversation
sphinx/themes/basic/theme.conf
Outdated
@@ -7,7 +7,7 @@ sidebars = localtoc.html, relations.html, sourcelink.html, searchbox.html | |||
[options] | |||
nosidebar = false | |||
sidebarwidth = 230 | |||
body_min_width = 450 | |||
body_min_width = 300 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is any reason to choose this value?
I just searched the screensizes of well-used mobile devices. Some reports says 360px is smallest size at present.
https://www.browserstack.com/guide/ideal-screen-sizes-for-responsive-design
https://mediag.com/blog/popular-screen-resolutions-designing-for-all/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I picked it because it solved the bug. Another value could work fine if it also resolve the issue.
Some reports says 360px is smallest size at present. refs: - https://www.browserstack.com/guide/ideal-screen-sizes-for-responsive-design - https://mediag.com/blog/popular-screen-resolutions-designing-for-all/
I determined to use 360px for the new default value of |
Merged. Thank you for your contribution! |
The current 450px setting is too large for many small device width. It causes x-overflows that make the page appear broken and introduces difficulty reading on many phones.