Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ensure the graphviz filenames are reproducible.
Whilst working on the Reproducible Builds effort [0], we noticed that sphinx could generate output that is not reproducible. In particular, the graphviz extension module would construct filenames based on, inter alia, the contents of the `options` dictionary. As this contained the absolute build path of the source file embedded in the `docname` variable this meant that builds of documentation were not independent of where on a filesystem they were built from. Example filenames might be: - html/_images/graphviz-9e71e0f9ba91d0842b51211b676ec4adb7e7afb8.png + html/_images/graphviz-6241bbfd7ac6bd4e2ad9af451ab0dfb8719988d2.png We fix this by limiting how much of the `docname` variable ends up in the final constructed filename; I assume there is a good reason for including the `options` dictionary in the first place, otherwise we could simply omit it. [0] https://reproducible-builds.org # Conflicts: # sphinx/ext/graphviz.py
- Loading branch information