Merge pull request #7441 from tk0miya/7423_logging_non_string_object

Fix #7423: crashed when giving a non-string object to logger

CHANGES

@@ -22,6 +22,7 @@ Bugs fixed
 * #7418: std domain: duplication warning for glossary terms is case insensitive
 * #7438: C++, fix merging overloaded functions in parallel builds.
 * #7422: autodoc: fails with ValueError when using autodoc_mock_imports
+* #7423: crashed when giving a non-string object to logger
 
 Testing
 --------

sphinx/util/logging.py

@@ -412,7 +412,7 @@ def filter(self, record: logging.LogRecord) -> bool:
                 message = record.msg  # use record.msg itself
 
             if location:
-                raise SphinxWarning(location + ":" + message)
+                raise SphinxWarning(location + ":" + str(message))
             else:
                 raise SphinxWarning(message)
         else:

tests/test_util_logging.py

@@ -48,6 +48,14 @@ def test_info_and_warning(app, status, warning):
     assert 'message5' in warning.getvalue()
 
 
+def test_Exception(app, status, warning):
+    logging.setup(app, status, warning)
+    logger = logging.getLogger(__name__)
+
+    logger.info(Exception)
+    assert "<class 'Exception'>" in status.getvalue()
+
+
 def test_verbosity_filter(app, status, warning):
     # verbosity = 0: INFO
     app.verbosity = 0