Merge pull request #9190 from tk0miya/9189_ValueError_for_property

Fix #9189: autodoc: crashed by ValueError on generating signature of property
sphinx-doc · May 10, 2021 · 7c16981 · 7c16981
2 parents f73e061 + 23fcb91
commit 7c16981
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGES b/CHANGES
@@ -16,6 +16,9 @@ Features added
 Bugs fixed
 ----------
 
+* #9189: autodoc: crashed when ValueError is raised on generating signature
+  from a property of the class
+
 Testing
 --------
 

diff --git a/sphinx/ext/autodoc/__init__.py b/sphinx/ext/autodoc/__init__.py
@@ -2570,7 +2570,7 @@ def add_directive_header(self, sig: str) -> None:
                                self.fullname, exc)
                 return None
             except ValueError:
-                raise
+                return None
 
 
 class NewTypeAttributeDocumenter(AttributeDocumenter):