Skip to content

Commit

Permalink
Fix search unnecessarily requiring source files
Browse files Browse the repository at this point in the history
This seems to have been a mistake with #4022 the ajax call functions correctly without the source files being included in the build (they are never used).

I have tested this out on several themes and now everything works correctly with `html_copy_source = False`
  • Loading branch information
Blendify authored and tk0miya committed Apr 24, 2021
1 parent a74b435 commit 634b05f
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions sphinx/themes/basic/static/searchtools.js
Expand Up @@ -276,7 +276,7 @@ var Search = {
setTimeout(function() {
displayNextItem();
}, 5);
} else if (DOCUMENTATION_OPTIONS.HAS_SOURCE) {
} else {

This comment has been minimized.

Copy link
@zzzeek

zzzeek Jul 15, 2021

im still tracking down if this was maybe reverted? but it breaks SQLAlchemy's search. no idea why

This comment has been minimized.

Copy link
@zzzeek

zzzeek Jul 15, 2021

see #9456. as this seems to be based on an option can this be reverted?

$.ajax({url: requestUrl,
dataType: "text",
complete: function(jqxhr, textstatus) {
Expand All @@ -289,12 +289,6 @@ var Search = {
displayNextItem();
}, 5);
}});
} else {
// no source available, just display title
Search.output.append(listItem);
setTimeout(function() {
displayNextItem();
}, 5);
}
}
// search finished, update title and status message
Expand Down

0 comments on commit 634b05f

Please sign in to comment.