Skip to content

Commit

Permalink
Autodoc: Pass namespace to skip-member callback
Browse files Browse the repository at this point in the history
  • Loading branch information
JelteF committed Oct 9, 2015
1 parent 19f9c9f commit 3926e1b
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion sphinx/ext/autodoc.py
Expand Up @@ -810,7 +810,7 @@ def filter_members(self, members, want_all):
# let extensions preprocess docstrings
skip_user = self.env.app.emit_firstresult(
'autodoc-skip-member', self.objtype, membername, member,
not keep, self.options)
self.fullname, not keep, self.options)
if skip_user is not None:
keep = not skip_user

Expand Down
2 changes: 1 addition & 1 deletion sphinx/ext/napoleon/__init__.py
Expand Up @@ -307,7 +307,7 @@ def _process_docstring(app, what, name, obj, options, lines):
lines[:] = result_lines[:]


def _skip_member(app, what, name, obj, skip, options):
def _skip_member(app, what, name, obj, namespace, skip, options):
"""Determine if private and special class members are included in docs.
The following settings in conf.py determine if private and special class
Expand Down
2 changes: 1 addition & 1 deletion tests/test_autodoc.py
Expand Up @@ -93,7 +93,7 @@ def process_signature(app, what, name, obj, options, args, retann):
return '42', None


def skip_member(app, what, name, obj, skip, options):
def skip_member(app, what, name, obj, namespace, skip, options):
if name in ('__special1__', '__special2__'):
return skip
if name.startswith('_'):
Expand Down
8 changes: 4 additions & 4 deletions tests/test_ext_napoleon.py
Expand Up @@ -128,13 +128,13 @@ def assertSkip(self, what, member, obj, expect_skip, config_name):
app.config = Config()
setattr(app.config, config_name, True)
if expect_skip:
self.assertEqual(skip, _skip_member(app, what, member, obj, skip,
mock.Mock()))
self.assertEqual(skip, _skip_member(app, what, member, obj, '',
skip, mock.Mock()))
else:
self.assertFalse(_skip_member(app, what, member, obj, skip,
self.assertFalse(_skip_member(app, what, member, obj, '', skip,
mock.Mock()))
setattr(app.config, config_name, False)
self.assertEqual(skip, _skip_member(app, what, member, obj, skip,
self.assertEqual(skip, _skip_member(app, what, member, obj, '', skip,
mock.Mock()))

def test_namedtuple(self):
Expand Down

0 comments on commit 3926e1b

Please sign in to comment.