Skip to content

Commit

Permalink
Merge pull request #4821 from tk0miya/4818_warnings_on_including
Browse files Browse the repository at this point in the history
Improve warning messages during including (refs: #4818)
  • Loading branch information
tk0miya committed Apr 22, 2018
2 parents d505d23 + a4dbb6e commit 0db15c9
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGES
Expand Up @@ -71,6 +71,7 @@ Features added
* #4834: Ensure set object descriptions are reproducible.
* #4828: Allow to override :confval:`numfig_format` partially. Full definition
is not needed.
* Improve warning messages during including (refs: #4818)

Bugs fixed
----------
Expand Down
24 changes: 23 additions & 1 deletion sphinx/directives/other.py
Expand Up @@ -8,6 +8,7 @@
"""

import re
from contextlib import contextmanager

from docutils import nodes
from docutils.parsers.rst import directives
Expand Down Expand Up @@ -436,14 +437,35 @@ class Include(BaseInclude, SphinxDirective):

def run(self):
# type: () -> List[nodes.Node]
current_filename = self.env.doc2path(self.env.docname)
if self.arguments[0].startswith('<') and \
self.arguments[0].endswith('>'):
# docutils "standard" includes, do not do path processing
return BaseInclude.run(self)
rel_filename, filename = self.env.relfn2path(self.arguments[0])
self.arguments[0] = filename
self.env.note_included(filename)
return BaseInclude.run(self)
with patched_warnings(self, current_filename):
return BaseInclude.run(self)


@contextmanager
def patched_warnings(directive, parent_filename):
# type: (BaseInclude, unicode) -> Generator[None, None, None]
"""Add includee filename to the warnings during inclusion."""
try:
original = directive.state_machine.insert_input

def insert_input(input_lines, source):
# type: (Any, unicode) -> None
source += ' <included from %s>' % parent_filename
original(input_lines, source)

# patch insert_input() temporarily
directive.state_machine.insert_input = insert_input
yield
finally:
directive.state_machine.insert_input = original


def setup(app):
Expand Down

0 comments on commit 0db15c9

Please sign in to comment.