align and caption #40
Conversation
There was a problem hiding this comment.
I checked the pre-build and it seems wrapping the video tags in a div is defaulting to center. Can you make sure that default remains consistently to the left ?
Can you add an example for each alignement so the users can feel the difference (and we can visually check it works as expected) ?
Can you regenerate the tests, adding the div is breaking every build.
| :align: right | ||
|
|
||
| For consistency with previous versions, which not support align, the default value of align 'left' when the it is not set. | ||
| If you want to use the 'default' defined by theme, you need to, manually, set it to 'default': |
There was a problem hiding this comment.
default: <not setted> = left
however, setting to 'default' = <the default in theme>
The puzzling word 'default'.
Or no longer required to be consistent with the previous versions?
There was a problem hiding this comment.
In which theme did you faced "default" ?
There was a problem hiding this comment.
sphinx_book_theme, pydata_sphinx_theme
There was a problem hiding this comment.
Please decide default alignment: follow past versions, or let the theme control?
Once determined and modified you can merge.
add align and caption.
related to : #38 #39