Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build-system dependencies #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dvzrv
Copy link

@dvzrv dvzrv commented Jan 9, 2023

pyproject.toml:
Update setuptools-scm to >= 7.1.0 to drop the requirement for setuptools-scm-git-archive (since the functionality is included since 7.0.0).
Update requirement for setuptools accordingly.

archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Jan 9, 2023
…depends.

Remove python-setuptools-scm-git-archive from makedepends by applying upstreamed patch:
sphinx-contrib/sphinxcontrib-towncrier#80

git-svn-id: file:///srv/repos/svn-community/svn@1382179 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Jan 9, 2023
…depends.

Remove python-setuptools-scm-git-archive from makedepends by applying upstreamed patch:
sphinx-contrib/sphinxcontrib-towncrier#80

git-svn-id: file:///srv/repos/svn-community/svn@1382179 9fca08f4-af9d-4005-b8df-a31f2cc04f65
@webknjaz
Copy link
Member

webknjaz commented Jan 9, 2023

This will probably need to wait until I drop Python 3.6.

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #80 (2fcfcb2) into master (729b600) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   64.63%   64.63%           
=======================================
  Files          14       14           
  Lines         246      246           
  Branches       30       30           
=======================================
  Hits          159      159           
  Misses         86       86           
  Partials        1        1           

@dvzrv
Copy link
Author

dvzrv commented Jan 10, 2023

This will probably need to wait until I drop Python 3.6.

I didn't even notice you still support 3.6. Is there a reason for it? After all, upstream already EOL'd it :)

@webknjaz
Copy link
Member

webknjaz commented Jan 10, 2023

I usually don't rush to drop support if there's no compelling reason to do so. Especially, in small projects, where it takes more effort than just leaving it as is. Plus, in this project it is much more important to work on adding the integration tests to improve the coverage and be able to stop shipping only alpha versions, plus use a better trove classifier for stability.

FWIW, from the Python packaging perspective, I declare minimum versions with the software features needed and then, it works with the newer versions too. Bumping the lower bound doesn't seem justified right now.
But thanks for bringing this to my attention — I should really test building dists with the lowest supported deps, including the runtime/interpreter so such a breaking change would be noticeable in CI.

Re:patch — I think, that it could be acceptable now if instead of replacing the entries it made use of env markers to have them as is for Python 3.6 and only add the updated deps for Python 3.7+ (just 7.0). Note that setuptools-scm 7+ no longer declares the toml extra so it's not needed anymore. Oh, and one more thing that is missing from this patch is updating .git_archival.txt — the newer plugin version makes use of newer Git features and requires a newer template there — you can take that file from this plugin's Git tree itself.

pyproject.toml:
Update setuptools-scm to >= 7.1.0 to drop the requirement for
setuptools-scm-git-archive (since the functionality is included since
7.0.0).
Update requirement for setuptools accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants