Copy parse_rule since it was removed in werkzeug 2.2 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also needed to remove the import in def translate_werkzeug_rule(rule):
from werkzeug.routing import parse_rule
...With that, my build errors are fixed. |
|
@vLabayen Good catch! I have applied that change to this PR |
|
Any update on this issue? It would be great to use the latest version of flask/werkzeug |
|
@kasium we're just waiting for a maintainer to merge this PR. I'm using the code from my fork and it works for me, but I don't know if anyone else has tested it. |
|
@ashb would somebody be so kind to check this PR and do a release? |
|
@kasium Yes of course, sorry for not seeing it! |
ashb
approved these changes
Nov 14, 2022
|
1.8.1 released! Better late then never right? |
MonkeyDo
added a commit
to metabrainz/listenbrainz-server
that referenced
this pull request
Mar 21, 2023
Since werkzeug 2.2 a missing method is causing autohttp to break the build. New version fixes the issue: sphinx-contrib/httpdomain#61 (comment)
amCap1712
pushed a commit
to metabrainz/listenbrainz-server
that referenced
this pull request
Mar 21, 2023
Since werkzeug 2.2 a missing method is causing autohttp to break the build. New version fixes the issue: sphinx-contrib/httpdomain#61 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #60.
Code from https://github.com/python-restx/flask-restx/pull/463/files, verified against https://github.com/pallets/werkzeug/blob/2.1.x/src/werkzeug/routing.py#L215.