Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Getting the value of a StringToString pflag #874

Merged
merged 7 commits into from May 9, 2020
Merged

Fix: Getting the value of a StringToString pflag #874

merged 7 commits into from May 9, 2020

Commits on Mar 28, 2020

  1. add parsing for stringToString flags

    @terev
    terev committed Mar 28, 2020
    Copy the full SHA
    6d67515 View commit details
    Browse the repository at this point in the history

  2. add logic to return flags default if not val set, add a test

    @terev
    terev committed Mar 28, 2020
    Copy the full SHA
    326772e View commit details
    Browse the repository at this point in the history

  3. extract parsing into single func

    @terev
    terev committed Mar 28, 2020
    Copy the full SHA
    61c17d0 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2020

  1. add a few more cases

    @terev
    terev committed Mar 29, 2020
    Copy the full SHA
    21e376d View commit details
    Browse the repository at this point in the history

  2. return nil if unable to parse instead of panicing

    @terev
    terev committed Mar 29, 2020
    Copy the full SHA
    d6288da View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2020

  1. return map[string]interface in order to work with cast.ToStringMap

    @terev
    terev committed Apr 30, 2020
    Copy the full SHA
    018de44 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. mostly copy pflags implementation of the conversion to a stringtostring

    @terev
    terev committed May 5, 2020
    Copy the full SHA
    c633cc5 View commit details
    Browse the repository at this point in the history