Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to save file with no extension #813

Merged
merged 4 commits into from Feb 19, 2020
Merged

Add support to save file with no extension #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1b6c1d
Add support to save file with no extension
gssbzn Dec 15, 2019
cc8e021
Update viper_test.go
gssbzn Dec 15, 2019
8f40d15
Update viper_test.go
gssbzn Dec 15, 2019
717d682
PR comments
gssbzn Jan 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 10 additions & 3 deletions viper.go
View file
Open in desktop
Expand Up @@ -1418,11 +1418,18 @@ func (v *Viper) SafeWriteConfigAs(filename string) error {

func (v *Viper) writeConfig(filename string, force bool) error {
jww.INFO.Println("Attempting to write configuration to file.")
var configType string

ext := filepath.Ext(filename)
if len(ext) <= 1 {
return fmt.Errorf("filename: %s requires valid extension", filename)
if ext != "" {
configType = ext[1:]
} else {
configType = v.configType
}
configType := ext[1:]
if configType == "" {
return fmt.Errorf("config type could not be determined for %s", filename)
}

if !stringInSlice(configType, SupportedExts) {
return UnsupportedConfigError(configType)
}
Expand Down