Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cannot write hidden file without extension #1064

Merged
merged 2 commits into from Sep 19, 2021
Merged

Fix cannot write hidden file without extension #1064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b56493f
Add test for cannot write hidden file without extension
serazoli Jan 15, 2021
a5b23ef
fix cannot write hidden file without extension (#1017)
serazoli Jan 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion viper.go
View file
Open in desktop
Expand Up @@ -1537,7 +1537,7 @@ func (v *Viper) writeConfig(filename string, force bool) error {
var configType string

ext := filepath.Ext(filename)
if ext != "" {
if ext != "" && ext != filepath.Base(filename) {
configType = ext[1:]
} else {
configType = v.configType
Expand Down
17 changes: 17 additions & 0 deletions viper_test.go
View file
Open in desktop
Expand Up @@ -1690,6 +1690,23 @@ func TestSafeWriteConfigAsWithExistingFile(t *testing.T) {
assert.True(t, ok, "Expected ConfigFileAlreadyExistsError")
}

func TestWriteHiddenFile(t *testing.T) {
v := New()
fs := afero.NewMemMapFs()
fs.Create("/test/.config")
v.SetFs(fs)

v.SetConfigName(".config")
v.SetConfigType("yaml")
v.AddConfigPath("/test")

err := v.ReadInConfig()
require.NoError(t, err)

err = v.WriteConfig()
require.NoError(t, err)
}

var yamlMergeExampleTgt = []byte(`
hello:
pop: 37890
Expand Down