Add RemoveFlag() function #358
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was raising this error, which was added in go 1.10: ./flag_test.go:1242:3: fmt.Println arg list ends with redundant newline
|
|
tiegz
commented
Sep 15, 2022
| if len(flagSet.formal) != 1 { | ||
| t.Errorf("Unexpected result adding a Flag to a FlagSet %v", flagSet) | ||
| } | ||
| } |
There was a problem hiding this comment.
Backfilling this test for AddFlag().
tiegz
force-pushed
the
tiegz/allow-removing-flags
branch
from
daa8925
to
87758c1
Compare
|
ping |
hoshsadiq
pushed a commit
to zulucmd/zflag
that referenced
this pull request
Apr 23, 2023
This adds the ability to remove a Flag from a FlagSet, e.g. `flagSet.RemoveFlag("my-flag")`
My end-goal is to allow cobra commands to opt-out of PersistentFlags() that they inherit. Please LMK if I'm on the wrong track here.
(plus a few formatting changes)
Merge spf13#358
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to remove a Flag from a FlagSet, e.g.
flagSet.RemoveFlag("my-flag")My end-goal is to allow cobra commands to opt-out of PersistentFlags() that they inherit. Please LMK if I'm on the wrong track here.
(plus a few formatting changes)