remove dead code for checking error nil

[yashbhutwala]

Here is the previous dead code:

1. Assigning: "err" = "nil".
2. At condition "err != nil", the value of "err" must be "nil".
3. The condition "err != nil" cannot be true.

[CLAassistant]

All committers have signed the CLA.

[cornfeedhobo]

We should look through git history to see what the reasoning is for this happening

[yashbhutwala]

This looks like the offending commit: b22fc70#diff-908f4c077f45928d663a0b84f166e7bcR96 via git blame: https://github.com/spf13/pflag/blame/master/string_array.go#L36

[yashbhutwala]

doesn't look like there was much review for that PR: #216, so seems like a honest mistake + lack of review process.

[cornfeedhobo]

@yashbhutwala Ahh yes, I see. This looks like a mistake from a copy-pasta event. Unless you protest, I'd like to apply this on my fork later (or you can submit an equivalent PR). Thanks!!

[yashbhutwala]

huh? why do you maintain your own fork? Is this project not community maintained? If not, maybe there should be a note in the top level README. @spf13?

[cornfeedhobo]

@yashbhutwala it is haphazardly maintained. I've tried to probe the maintainers on various issues and get varying levels of responses (you can look at my PR for a test that has been broken for 2+ years now). I'm just maintaining a fork now :)

Edit: This is kind of the history of pflag. They forked it from a person that stopped maintaining it, and I'm doing that now.