Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump module import from github.com/spf13/pflag@v1.0.3 #962

Closed
wants to merge 1 commit into from

Conversation

cfromknecht
Copy link

Update to pflag@v1.0.5, running now to execute tests. Will remove replace statement once spf13/pflag#219 or a similar fix lands and has a real tag

@CLAassistant
Copy link

CLAassistant commented Sep 17, 2019

CLA assistant check
All committers have signed the CLA.

@umarcor
Copy link
Contributor

umarcor commented Sep 18, 2019

Hi @cfromknecht! IMHO, this PR should have been a draft. Since I think that it is not possible to change it now, please:

  • add a note in bold capital letters to make it clear that THIS PR CANNOT BE MERGED.
  • optionally, close it straightaway, and open it again when it is ready to be merged.

It is not good ettiquete to use a PR of a third party project to test some enhancement/fix that you have implemented in your fork of a dependency. I understand that you did it because both pflag and cobra are in @spf13's namespace. Still, these are independent projects, with different maintainers/contributors. Precisely, you brought attention about a transient issue that is irrelevant for cobra. This is so, because v1.0.4 is marked as 'pre-release', so it was not a candidate.

@cfromknecht
Copy link
Author

Hi @umarcor, thanks for your thoughts. I agree that this PR is no longer necessary, I will close it and allow the authors to update at their discretion.

@cfromknecht cfromknecht deleted the fix-pflag-mod branch September 18, 2019 21:11
@umarcor
Copy link
Contributor

umarcor commented Sep 18, 2019

v1.0.5 was published as stable 20min ago: https://github.com/spf13/pflag/releases/tag/v1.0.5. You might update your branch accordingly, and reopen this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants