Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit non-zero exit code upon non-runnable subcommand #922

Merged
merged 6 commits into from Aug 1, 2019
Merged

Emit non-zero exit code upon non-runnable subcommand #922

merged 6 commits into from Aug 1, 2019

Commits on Jul 30, 2019

  1. Add ignore of cobra posix binary and all of intellij generated files

    @bruceadowns
    bruceadowns committed Jul 30, 2019
    Copy the full SHA
    30c25f3 View commit details
    Browse the repository at this point in the history

  2. Add idiomatic handling of go error in distinct main func

    @bruceadowns
    bruceadowns committed Jul 30, 2019
    Copy the full SHA
    d0edbca View commit details
    Browse the repository at this point in the history

  3. Return an error in the case of unrunnable subcommand 

    * credit to @chriswhelix for initial commit
    @bruceadowns
    bruceadowns committed Jul 30, 2019
    Copy the full SHA
    8b780f4 View commit details
    Browse the repository at this point in the history

  4. Correct all complaints from golint 

    * i.e.
* go get golang.org/x/lint/golint
* go list ./... | xargs golint
    @bruceadowns
    bruceadowns committed Jul 30, 2019
    Copy the full SHA
    15a2441 View commit details
    Browse the repository at this point in the history

  5. Correct all complaints from goimports 

    * i.e.
* go get golang.org/x/tools/cmd/goimports
* goimports -w *.go
* goimports -w cobra/
    @bruceadowns
    bruceadowns committed Jul 30, 2019
    Copy the full SHA
    40b62f6 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2019

  1. Adjustments per PR review feedback from @BoGeM

    @bruceadowns
    bruceadowns committed Aug 1, 2019
    Copy the full SHA
    dfb2aba View commit details
    Browse the repository at this point in the history