Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #911

Closed
wants to merge 1 commit into from
Closed

Update README.md #911

wants to merge 1 commit into from

Conversation

zwhitchcox
Copy link

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@umarcor
Copy link
Contributor

umarcor commented Jul 19, 2019

@zwhitchcox, is this an unwanted PR? Or is it an unconventional way to desperately ask for help?

@zwhitchcox
Copy link
Author

No just a joke, because I couldn't get it to work, and it was ironic, because the docs were talking about how "smart" it was.

@zwhitchcox zwhitchcox closed this Jul 19, 2019
@zwhitchcox
Copy link
Author

Honestly though, I tried like 15 different combinations, and none of them worked

@umarcor
Copy link
Contributor

umarcor commented Jul 22, 2019

Honestly though, I tried like 15 different combinations, and none of them worked

It'd be helpful if you opened an issue telling the specific combinations you used and the errors/unexpected results you got. I understand that it can be frustrating, but unfortunately this kind of PR does neither help you nor us.

More precisely, this part of the README needs to be updated and there is an open PR about it: https://github.com/spf13/cobra/pull/904/files. Moreover, in #910 you'll find a practical example for a user asking about how to use cobra in a project.

@jharshman
Copy link
Collaborator

This kind of noise is extremely unhelpful and unwanted. As @umarcor mentioned there are Issues and PRs that already address the documentation update which you would have seen if you took the time.

Repository owner locked as too heated and limited conversation to collaborators Jul 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants