Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add golangci-lint, and fix linting issues #876

Closed
wants to merge 21 commits into from
Closed

Add golangci-lint, and fix linting issues #876

wants to merge 21 commits into from

Commits on Jan 6, 2020

  1. feat(travis-ci): use golangci-lint 

    deprecate go 1.10.x and 1.11.x
    @umarcor
    umarcor committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    37b6a19 View commit details
    Browse the repository at this point in the history

  2. use sort.Strings(...) instead of sort.Sort(sort.StringSlice(...))

    @umarcor
    umarcor committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    84e7706 View commit details
    Browse the repository at this point in the history

  3. reduce size of struct

    @umarcor
    umarcor committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    44c8ae4 View commit details
    Browse the repository at this point in the history

  4. add helpers: 'er', 'Er' and 'WrStringAndCheck', use 'io.StringWriter'

    @umarcor
    umarcor committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    7b62ee1 View commit details
    Browse the repository at this point in the history

  5. handle error return values

    @umarcor
    umarcor committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    d6568ba View commit details
    Browse the repository at this point in the history

  6. make string ''\)\n' a constant and check error

    @umarcor
    umarcor committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    8263406 View commit details
    Browse the repository at this point in the history

  7. make 'one two' a constant

    @umarcor
    umarcor committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    0be19cd View commit details
    Browse the repository at this point in the history

  8. remove unused function 'checkStringOmits'

    @umarcor
    umarcor committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    26d6a02 View commit details
    Browse the repository at this point in the history

  9. remove unused field 'tc'

    @umarcor
    umarcor committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    c312af1 View commit details
    Browse the repository at this point in the history

  10. cobra: check error return values

    @umarcor
    umarcor committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    4656c87 View commit details
    Browse the repository at this point in the history

  11. remove unused 'isEmpty', 'executeTemplate', 'writeStringToFile', 'upd… 

    …ate' and 'checkLackFiles'
    @umarcor
    umarcor committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    467feac View commit details
    Browse the repository at this point in the history

  12. remove unused 'writeToFile', 'commentifyString', 'stringInStringSlice… 

    …' and 'exists'
    @umarcor
    umarcor committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    e8777b0 View commit details
    Browse the repository at this point in the history

  13. doc: add utils 'er' and 'wrStringAndCheck'

    @umarcor
    umarcor committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    df76712 View commit details
    Browse the repository at this point in the history

  14. doc_test: add 'er'

    @umarcor
    umarcor committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    dcf0d55 View commit details
    Browse the repository at this point in the history

  15. doc: check error return values

    @umarcor
    umarcor committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    fa70495 View commit details
    Browse the repository at this point in the history

  16. add .gitattributes

    @umarcor
    umarcor committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    4c12cfe View commit details
    Browse the repository at this point in the history

  17. drop mitchellh/go-homedir (spf13#853), print to stderr in boilerplate (… 

    …spf13#774)

fix: root.go.golden and tpl/main.go
    @umarcor
    umarcor committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    cc49679 View commit details
    Browse the repository at this point in the history

  18. style(command_test)

    @umarcor
    umarcor committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    576d6e4 View commit details
    Browse the repository at this point in the history

  19. fix: add cobra/cmd/testproject to gitignore

    @umarcor
    umarcor committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    31f8371 View commit details
    Browse the repository at this point in the history

  20. fix gosec G204

    @umarcor
    umarcor committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    2d75916 View commit details
    Browse the repository at this point in the history

  21. ci: add go 1.13.x 

    * circleci: export GO111MODULE=on, add 1.13.x, remove 1.11.x
* travis: add go 1.13.x
    @umarcor
    umarcor committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    4fe7dea View commit details
    Browse the repository at this point in the history