Return error when usage was output due to non-runnable command #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chriswhelix Please resolve merge conflicts |
|
I've encountered the same issue, and agree that if an incorrect subcommand is specified, a non-zero exit code should be returned. This PR has sat for a year and now has conflicts, however I am willing to create a new PR to restart the conversation. @BoGeM, what do you think? |
n10v
approved these changes
Jul 30, 2019
|
@bruceadowns it would be great if you reopen the conversation. |
Ok, I will put a PR together. |
|
|
Close in favour of #922 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows programs to detect running a non-runnable command as a failure condition and return a non-zero exit code, if they want to. For most existing programs, it will probably result in that behavior by default (assuming they exit non-zero whenever Execute() returns an error).
Usage output in this scenario is also now sent to stderr instead of stdout, which is better for scripting and seems more consistent with surrounding code.
Fixes #582