Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More linting #2099

Merged
merged 2 commits into from Apr 1, 2024
Merged

More linting #2099

merged 2 commits into from Apr 1, 2024

Conversation

scop
Copy link
Contributor

@scop scop commented Jan 15, 2024

Some old patches I've had around, refreshed.

@github-actions github-actions bot added the area/docs-generation Generation of docs via Cobra label Jan 15, 2024
jpmcb
jpmcb reviewed Mar 10, 2024
View reviewed changes
Copy link
Collaborator

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - looks great. One small comment.

bash_completions.go Show resolved Hide resolved
marckhouzam
marckhouzam approved these changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marckhouzam marckhouzam added this to the 1.9.0 milestone Apr 1, 2024
@marckhouzam marckhouzam merged commit 6b5f577 into spf13:main Apr 1, 2024
16 checks passed
@scop scop deleted the refactor/more-linting branch April 1, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marckhouzam marckhouzam marckhouzam approved these changes

@jpmcb jpmcb jpmcb approved these changes

Assignees
No one assigned
Labels
area/docs-generation Generation of docs via Cobra
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scop @marckhouzam @jpmcb