Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for func in cobra.go #2094

Merged
merged 3 commits into from Dec 30, 2023
Merged

Add test for func in cobra.go #2094

merged 3 commits into from Dec 30, 2023

Conversation

korovindenis
Copy link
Contributor

Add test for:

  • rpad(s string, padding int) string
  • ld(s, t string, ignoreCase bool) int
  • stringInSlice(a string, list []string) bool

in cobra.go

@CLAassistant
Copy link

CLAassistant commented Dec 28, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

marckhouzam
marckhouzam reviewed Dec 29, 2023
View reviewed changes
Copy link
Collaborator

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @korovindenis.
More tests is always better.
Some small nits if you agree with them.

cobra_test.go Show resolved Hide resolved
cobra_test.go Show resolved Hide resolved
cobra_test.go Show resolved Hide resolved
@marckhouzam marckhouzam added this to the 1.9.0 milestone Dec 29, 2023
@marckhouzam marckhouzam added the kind/testing CI/CD, testing, etc. for cobra label Dec 29, 2023
marckhouzam
marckhouzam approved these changes Dec 30, 2023
View reviewed changes
Copy link
Collaborator

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@marckhouzam marckhouzam merged commit 0dec88e into spf13:main Dec 30, 2023
16 checks passed
@Dav-14 Dav-14 mentioned this pull request Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marckhouzam marckhouzam marckhouzam approved these changes

Assignees
No one assigned
Labels
kind/testing CI/CD, testing, etc. for cobra
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@korovindenis @CLAassistant @marckhouzam