Move newline to inside the DisableAutoGenTag block #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nirs
approved these changes
Oct 1, 2023
jpmcb
reviewed
Oct 28, 2023
There was a problem hiding this comment.
This seems fine. Is this more stylistic than anything? I'm surprised there are tools that have an opinion on markdown formatting. Or is it more that some version control tools don't want extra newlines at the end of files?
I'd like to understand more on why this is needed.
jpmcb
reviewed
Oct 28, 2023
| } | ||
| if !cmd.DisableAutoGenTag { | ||
| buf.WriteString("\n") | ||
| buf.WriteString("###### Auto generated by spf13/cobra on " + time.Now().Format("2-Jan-2006") + "\n") |
There was a problem hiding this comment.
If we fix not having newlines at the end of the file, we should also remove the newline from the autogenerated tag at the end of the file:
Suggested change
| buf.WriteString("###### Auto generated by spf13/cobra on " + time.Now().Format("2-Jan-2006") + "\n") | |
| buf.WriteString("###### Auto generated by spf13/cobra on " + time.Now().Format("2-Jan-2006")) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2029