Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(bash-v2): read directly to COMPREPLY on descriptionless short circuit #1700

Merged
merged 1 commit into from May 18, 2022
Merged

perf(bash-v2): read directly to COMPREPLY on descriptionless short circuit #1700

merged 1 commit into from May 18, 2022
+1 −3

Commits on May 17, 2022

  1. perf(bash-v2): read directly to COMPREPLY on descriptionless short ci… 

    …rcuit

Not that it'd really matter that much performancewise given the level we
are at for this case, but this change makes the short circuit roughly
twice as fast on my box as it was for the 1000 rounds done in
marckhouzam/cobra-completion-testing.

Perhaps more importantly, this makes the code arguably slightly cleaner.
    @scop
    scop committed May 17, 2022
    Copy the full SHA
    431e145 View commit details
    Browse the repository at this point in the history