Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ambiguous tags: use 'viper' and remove 'useViper' #1584

Closed
wants to merge 1 commit into from
Closed

Fix ambiguous tags: use 'viper' and remove 'useViper' #1584

wants to merge 1 commit into from

Conversation

atompi
Copy link

@atompi atompi commented Jan 21, 2022

This approach is more appropriate than just modifying the README. Contrast: #1571

@github-actions github-actions bot added the area/cli [deprecated] For the cobra CLI !!! moved to spf13/cobra-cli label Jan 21, 2022
@acehinnnqru
Copy link

Maybe they have reasons to use 'useViper'?

@marckhouzam
Copy link
Collaborator

I also like viper as a key for the configuration file. However, from what I can see from the git history, useViper was the name that was used from the very beginning. Therefore, for backwards-compatibility reasons, we should stay with useViper. There may be configuration files out there that use the correct useViper key (after having figured out the documentation was wrong).

I will therefore close this in favour of #1571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/cli [deprecated] For the cobra CLI !!! moved to spf13/cobra-cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atompi @acehinnnqru @marckhouzam