Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize first letter of default completion command short description #1540

Closed
wants to merge 1 commit into from

Conversation

Horgix
Copy link

@Horgix Horgix commented Nov 22, 2021

Currently, the default completion command has the following short description: generate the autocompletion script for the specified shell. Note that generate is not capitalized.

Meanwhile, the again default help command has the following short description: Help about any command. Note that Help is capitalized.

This mean that a default project will have the following Help message:

Available Commands:
  completion  generate the autocompletion script for the specified shell
  help        Help about any command

This is kinda inconsistent and is more noticeable in real life scenario, such as the Hugo CLI here:

screenshot_2021-11-22-155724_761x280_selection

Yes, this is definitely very minor but you know... OCD and stuff 😅

…tion

... to make it more consistent with other options
... such as the default `help` one
... or ones from the most popular cobra users
@CLAassistant
Copy link

CLAassistant commented Nov 22, 2021

CLA assistant check
All committers have signed the CLA.

@marckhouzam
Copy link
Collaborator

Thanks @Horgix, that issue had been bothering many people 😀

Duplicate of #1455

@Horgix
Copy link
Author

Horgix commented Nov 23, 2021

Thanks @Horgix, that issue had been bothering many people grinning

Wow, would sincerely have never believed so!

Duplicate of #1455

Thanks, I didn't find it when searching through existing issues/PRs 😅 Should I just close this one then? Asking because the other one hasn't been merged though having been sent 4 months ago

@marckhouzam
Copy link
Collaborator

Yes please close this one. The other should get merged once the maintainers find the time.

Thanks again!

@Horgix
Copy link
Author

Horgix commented Nov 23, 2021

Yes please close this one. The other should get merged once the maintainers find the time.

Thanks again!

Thanks for the prompt answer 🙂

Closing this. Have a nice day!

@Horgix Horgix closed this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants