Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete subcommands when TraverseChildren is set #1171

Merged
merged 2 commits into from Sep 9, 2020

Commits on Jul 20, 2020

  1. Complete subcommands when TraverseChildren is true in custom completion

    The current custom completion logic does not complete
    subcommands when a local flag is set. This is good unless
    TraverseChildren is set to true where local flags
    can be set on parent commands.
    
    This commit allows subcommands to be completed
    if TraverseChildren is set to true on the root cmd.
    
    Closes spf13#1170
    
    Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
    Luap99 committed Jul 20, 2020
    Copy the full SHA
    7034e0c View commit details
    Browse the repository at this point in the history
  2. Complete subcommands when TraverseChildren is true in bash completion

    The current bash completion logic does not complete
    subcommands when a local flag is set. There is also a bug
    where subcommands are sometimes still getting completed. see: spf13#1172
    
    If TraverseChildren is true we should allow subcommands
    to be completed even if a local flag is set.
    
    Closes spf13#1172
    
    Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
    Luap99 committed Jul 20, 2020
    Copy the full SHA
    a3adff6 View commit details
    Browse the repository at this point in the history