Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add golangci-lint in project using cobra #1150

Merged
merged 1 commit into from Jul 15, 2020
Merged

Add golangci-lint in project using cobra #1150

merged 1 commit into from Jul 15, 2020

Conversation

sayboras
Copy link
Contributor

@sayboras sayboras commented Jul 1, 2020

Add golangci-lint in project using cobra

@CLAassistant
Copy link

CLAassistant commented Jul 1, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

jpmcb
jpmcb approved these changes Jul 2, 2020
View reviewed changes
Copy link
Collaborator

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!! 🎈

@umarcor
Copy link
Contributor

umarcor commented Jul 4, 2020

Ref #1044.

@wfernandes wfernandes merged commit b95db64 into spf13:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmcb jpmcb jpmcb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sayboras @CLAassistant @umarcor @jpmcb @wfernandes