Fix #1056

[ob-stripe]

Restore previous behavior for additional help topic commands.

Fixes #1056.

cc @bruceadowns

[CLAassistant]

All committers have signed the CLA.

[jharshman]

@ob-stripe - thanks for finding this bug. Quick question, what do you think of just reverting to the behavior that we had before #922 ?

[ob-stripe]

Good question. It's debatable whether not providing a subcommand to a command that expects one should return an error or not.

I'm one of the maintainers of the Stripe CLI which makes heavy use of nested subcommands. For example, running this:

$ stripe charges
Usage:
  stripe charges <operation> [parameters...]

Available Operations:
  capture
  create
  list
  retrieve
  update

...

For our case at least, I think simply displaying the help message and exiting with status code 0 is preferable. The charges command did its job: display the help message listing available subcommands.

If that's an option, I would prefer reverting to the previous behavior entirely. Maybe we can have the best of both worlds by making the new behavior available on demand?

[jharshman]

I'm reviewing the issues that brought the change in #922 about. From what I can tell, it was a debate about whether or not Cobra should emit an exit code for a command that doesn't exist.

My preference here is to lean on RunE. To handle the return of an error code. From my experience, this handles the case nicely.

Since this change really just landed in 0.0.6, I'm definitely okay reverting it.

[ob-stripe]

Awesome. Feel free to close this PR then.

[jharshman]

closing in favor of #1068