Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace viper with useViper in README.md #19

Merged
merged 1 commit into from Mar 14, 2022

Conversation

acehinnnqru
Copy link
Contributor

The flag viper in ~/.cobra.yaml example has no impact.
The correct flag is useViper according to source code of cobra-cli.

@CLAassistant
Copy link

CLAassistant commented Mar 14, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acehinnnqru - can you sign the CLA please? Then we can merge.

@acehinnnqru
Copy link
Contributor Author

I have signed the CLA. Thanks.

@marckhouzam
Copy link
Collaborator

This is the equivalent to spf13/cobra#1571, which confirms the importance of this change.

Copy link
Collaborator

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marckhouzam marckhouzam merged commit ffbcf1e into spf13:main Mar 14, 2022
@marckhouzam marckhouzam added this to the v1.3.1 milestone Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants