Initialize cobra-cli repo #1
Conversation
liggitt
force-pushed
the
init
branch
3 times, most recently
from
627f0c9
to
a633892
Compare
Signed-off-by: Jordan Liggitt <liggitt@google.com>
Signed-off-by: Jordan Liggitt <liggitt@google.com>
Signed-off-by: Jordan Liggitt <liggitt@google.com>
Signed-off-by: Jordan Liggitt <liggitt@google.com>
|
@liggitt This looks good, but I'm going to wait for a bit on merging it until I can resolve my concern with DCOBot. There's a thread on the Cobra project about using it over CLA Assistant and I thought I'd try it here first. In reviewing it I had a concern about how the signing happens on the commit without every acknowledging the agreement (unlike CLA Assistant where you have to visually see the agreement and click "I Agree"). I brought this up with a lawyer and they shared my concern. In legal terms this is an inferred agreement, and typically very weak. It's well established that clicking I accept connotes acceptance, but it's not clear that signing a commit has any legal precedence yet. I'm going to bring this up with someone with deeper expertise in the legal field of open source and see if I can get more guidance. If this can wait for a few days that would be best. |
|
ack |
|
sounds like the consensus was to keep the |
@spf13, any update on this bit? |
|
Meeting today on it.
…On Thu, Feb 17, 2022 at 10:47 AM Jordan Liggitt ***@***.***> wrote:
I'm going to bring this up with someone with deeper expertise in the legal
field of open source and see if I can get more guidance. If this can wait
for a few days that would be best.
@spf13 <https://github.com/spf13>, any update on this bit?
—
Reply to this email directly, view it on GitHub
<#1 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABKKZHGUE4SZMPSYCMZQUDU3UJ7FANCNFSM5N7QSZLA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I have an update which you can read spf13/cobra#1555 (comment) As a result of these findings, I'll go ahead and setup CLA Assistant on this repo too. |
|
I've setup CLA Assistant but I believe that because this PR predated it it's not being required. It might require to resubmit the PR to trigger it. @liggitt would that be too much trouble. I'm not sure what alternatives we have. |
|
|
|
That worked!! Thanks @liggitt |
| - 14 | ||
| - 15 | ||
| - 16 | ||
| - 17 |
There was a problem hiding this comment.
I would recommend that you also include Windows in the matrix and reduce the numbers by cutting one or two Go versions.
There was a problem hiding this comment.
We do test against windows here:
cobra-cli/.github/workflows/test.yml
Line 66 in 7c6e26a
And yes, will remove Go 14 and 15.
This PR sets up various housekeeping things for the new repo:
Because this repo placed the binary at the root, it makes the binary name change to
cobra-cli. Before merging any changes into this repo, we should make sure that's what we want, since that ripples to docs and usage, not just the install command (asked in spf13/cobra#1597 (comment))If we want to preserve the
cobrabinary, we should reinitialize it with the history placed under agithub.com/spf13/cobra-cli/cobrasubpackage.Preview of the configured CI runs passing at https://github.com/liggitt/cobra-cli/actions?query=branch%3Ainit