Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to have strict file creation behavior #374

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

natebrennand
Copy link

Workaround for #373

Adds an option to have MemMapFS fail when creating a file in a directory that DNE.

@CLAassistant
Copy link

CLAassistant commented Jul 25, 2022

CLA assistant check
All committers have signed the CLA.

@Frassle
Copy link

Frassle commented Apr 1, 2023

I'd consider it a bug that it ever allowed this in the first place. A file create on OsFs would fail, it would be less surprising if MemFs also had that behavior. We've had bugs slip by testing due to this difference, but I'm not sure we would have noticed that we need to turn strict mode on for MemFs if it was an option like this.

@natebrennand
Copy link
Author

I agree that it's a bug, but fixing it would be a breaking change.
Dunno that a v2 is anywhere on the horizon

@Frassle
Copy link

Frassle commented Apr 1, 2023

fixing it would be a breaking change.

Obligatory xkcd: https://xkcd.com/1172/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants