Fix sorting in IOFS.ReadDir #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently added a check for fs.ReadDirFile in IOFS.ReadDir, but forgot to apply a sort to the result as defined in the spec. This fixes that and adds a test case for it.
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Jul 27, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/spf13/afero](https://togithub.com/spf13/afero) | require | patch | `v1.9.0` -> `v1.9.2` | --- ### Release Notes <details> <summary>spf13/afero</summary> ### [`v1.9.2`](https://togithub.com/spf13/afero/releases/tag/v1.9.2) [Compare Source](https://togithub.com/spf13/afero/compare/v1.9.1...v1.9.2) #### What's Changed - Make mem.File implement fs.ReadDirFile by [@​bep](https://togithub.com/bep) in [spf13/afero#371 **Full Changelog**: spf13/afero@v1.9.1...v1.9.2 ### [`v1.9.1`](https://togithub.com/spf13/afero/releases/tag/v1.9.1) [Compare Source](https://togithub.com/spf13/afero/compare/v1.9.0...v1.9.1) #### What's Changed - Fix sorting in IOFS.ReadDir by [@​bep](https://togithub.com/bep) in [spf13/afero#372 **Full Changelog**: spf13/afero@v1.9.0...v1.9.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMzEuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEzMS4xIn0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added a check for fs.ReadDirFile in IOFS.ReadDir, but forgot to apply a sort to the
result as defined in the spec.
This fixes that and adds a test case for it.