Fix for some switch lock-ins for common terms #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove about from adjective, add it to adj-past as an adjective.
…look at the one before.
|
perfect. I'll finish these last 8 failing tests, and do a release today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
(Part of #1074)
The word "about" no longer is an afterWords switch for all switches utilizing _adj. It is still used for adj-past switches though.
Also
Fixes #1070
If "also" is the term previous in the sentence, use the next most previous term (if one exists), for the tests.
I'm sure there are edge cases being missed and other "lock-in" terms which may be causing issues. But I wanted to get this in before you publish the next release to take care of these more simple issues.
How does this look? I'm worried this might break certain sentences or phrases that we aren't testing for.