Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added interjections 馃敤 #1052

Closed
wants to merge 1 commit into from

Conversation

MarketingPip
Copy link
Contributor

Added a ton of missing expressions / interjections. All have been found from a frequency list of 30,000 most commonly used words & tagged via Wiktionary. Build tests have been passed previously before submitting this PR. 馃敤

ps; notice that 30,000 k mark - I have made some other lists to again based off this. Some dude named Spencer I was video / lecture was talking about this being average mark too for human vocabulary. 馃槈 So figured this would be a good idea / rule to build lexicon on.

@spencermountain
Copy link
Owner

spencermountain commented Sep 17, 2023

hey Jared - I think there may be some misunderstanding about adding words to the lexicon.
'yummy' is usually an adjective - 'it was yummy'- and 'boy', 'god' and 'man' are very common nouns.
Adding these words to the lexicon will change every occurance of 'man' to an Interjection.

If you add these words, and run npm run pack, you'll see the tests do not pass.
Let me know if I can help
cheers

@MarketingPip
Copy link
Contributor Author

MarketingPip commented Sep 18, 2023

@spencermountain funny you brought that up! Been at stacking verb lists up for us etc and seen / forget they were separated by various types 馃槱. But yeah - awesome point - my stupid ass just assumed since the build and tests passed this would be good.

If you want to help clean this list (would be appreciated). And if have a solution that can even help sort this + the other verbs I have collected for compromise etc! Feel free to share! As I think we both prefer not sorting 3000 + verbs 馃槱 lol

Ps; hope you are having / had an awesome weekend. 馃嵒

spencermountain added a commit that referenced this pull request Oct 16, 2023
@spencermountain
Copy link
Owner

hey Jared, I've added the following from this list onto dev:

  'eureka',
  'farewell',
  'yea',
  'nay',
  'yah',

thanks for your help
cheers

@MarketingPip
Copy link
Contributor Author

@spencermountain - awesome job! And thank you for your work / dedication to Compromise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants