Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SVG encoder #780

Closed

Conversation

patriksvensson
Copy link
Contributor

@patriksvensson patriksvensson commented Mar 27, 2022

This PR is mainly for discussion, so let's not merge it yet.

I've pretty much ported all the code for this PR from Rich: Textualize/rich#2101, so if we decide to merge it, we should make sure to add attribution.

  • Is this the road we want to take with SVG rendering, or should we try to build something similar to what @phil-scott-78 did with the Asciicast encoder?
  • Should this be in a separate repo, away from the core project?

Todo

  • Add proper attribution to Rich
  • Un-internalize the theme classes and the settings

Example

test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant