Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uncessary disabled for button #4926

Merged
merged 1 commit into from
May 21, 2024
Merged

Remove uncessary disabled for button #4926

merged 1 commit into from
May 21, 2024

Conversation

CarolineDenis
Copy link
Contributor

Fixes #4918

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • Import a spreadsheet
  • Try to map a field in the upload plan
  • Verify that the suggested mapping can be selected

@CarolineDenis CarolineDenis added this to the 7.9.6 milestone May 16, 2024
@CarolineDenis CarolineDenis requested review from sharadsw and a team May 16, 2024 20:55
@CarolineDenis
Copy link
Contributor Author

Screenshot 2024-05-16 at 1 56 04 PM

lexiclevenger
lexiclevenger approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@lexiclevenger lexiclevenger left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Import a spreadsheet
  • Try to map a field in the upload plan
  • Verify that the suggested mapping can be selected

Looks great, suggested mappings can be selected!

Screen.Recording.2024-05-17.at.11.13.25.AM.mov

@Areyes42 Areyes42 self-requested a review May 17, 2024 17:32
Areyes42
Areyes42 approved these changes May 17, 2024
View reviewed changes
Copy link

@Areyes42 Areyes42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Import a spreadsheet
  • Try to map a field in the upload plan
  • Verify that the suggested mapping can be selected

Works great! Suggested mappings can be properly selected.

Screen.Recording.2024-05-17.at.12.27.53.PM.mov

@CarolineDenis CarolineDenis merged commit e6e758c into production May 21, 2024
9 checks passed
@CarolineDenis CarolineDenis deleted the issue-4918 branch May 21, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharadsw sharadsw sharadsw approved these changes

@Areyes42 Areyes42 Areyes42 approved these changes

@lexiclevenger lexiclevenger lexiclevenger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: ✅Done
Milestone
7.9.6
Development

Successfully merging this pull request may close these issues.

Suggested mappings cannot be selected
4 participants
@CarolineDenis @sharadsw @Areyes42 @lexiclevenger