-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display create RS and Gallery tool only for factious RS with same type #4904
base: production
Are you sure you want to change the base?
Conversation
Triggered by 62c52e1 on branch refs/heads/issue-4898
what does Record Cet? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing instructions
- Go to data entry (ex CO)
- save form
- verify that Gallery icon and Create RS tool are not available
- create a new data entry form using the same table as in first step (ex CO)
- verify that Gallery icon and Create RS tool are not available
- save form
- verify that Gallery icon and Create RS tool are available
- create a new data entry form using another table than in first step (ex CE)
- verify that Gallery icon and Create RS tool are not available
- save
- verify that Gallery icon and Create RS tool are not available
Everything looks good, except saving the first CO still shows the Gallery icon as available. Is this intended behavior or a mistake in the testing instruction checklist?
Screen.Recording.2024-05-20.at.3.04.38.PM.mov
@Areyes42 , a mistake sorry for that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing instructions
- Go to data entry (ex CO)
- save form
- verify that Create RS tool are not available
- create a new data entry form using the same table as in first step (ex CO)
- verify that Gallery icon and Create RS tool are not available
- save form
- verify that Gallery icon and Create RS tool are available
- create a new data entry form using another table than in first step (ex CE)
- verify that Gallery icon and Create RS tool are not available
- save
- verify that Gallery icon and Create RS tool are not available
Looks good! Everything is behaving according to the instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Go to data entry (ex CO)
- save form
- verify that Create RS tool are not available
- create a new data entry form using the same table as in first step (ex CO)
- verify that Gallery icon and Create RS tool are not available
- save form
- verify that Gallery icon and Create RS tool are available
- create a new data entry form using another table than in first step (ex CE)
- verify that Gallery icon and Create RS tool are not available
- save
- verify that Gallery icon and Create RS tool are not available
Looks good, seems to have fixed everything.
Fixes #4898
Checklist
and self-explanatory (or properly documented)
Testing instructions