Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cloning option from certain resources #4902

Merged
merged 5 commits into from
May 21, 2024
Merged

Remove cloning option from certain resources #4902

merged 5 commits into from
May 21, 2024

Conversation

CarolineDenis
Copy link
Contributor

@CarolineDenis CarolineDenis commented May 10, 2024 •
edited

Fixes #4809

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • Go to app resource

  • Click on any resource with a visual editor (e.g. web links)

  • Verify that there is no clone option for:

  • TypeSearches

  • WebLinks

  • DataObjFormatters

  • UIFormatters

  • DataEntryTaskInit

  • InteractionsTaskInit

  • UserPreferences

  • CollectionPreferences

  • ExpressSearchConfig

  • leaflet-layers

@CarolineDenis CarolineDenis mentioned this pull request May 10, 2024
Closed
@CarolineDenis CarolineDenis added this to the 7.9.6 milestone May 13, 2024
@CarolineDenis @github-actions
Lint code with ESLint and Prettier
ccc8503 
Triggered by 18ab3dc on branch refs/heads/issue-4809
@CarolineDenis CarolineDenis marked this pull request as ready for review May 16, 2024 13:48
@CarolineDenis CarolineDenis requested a review from a team May 16, 2024 13:48
lexiclevenger
lexiclevenger requested changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@lexiclevenger lexiclevenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • TypeSearches
  • WebLinks
  • DataObjFormatters
  • UIFormatters
  • DataEntryTaskInit
  • InteractionsTaskInit
  • CollectionPreferences
  • ExpressSearchConfig
  • leaflet-layers
  • QueryFreqList
  • QueryExtraList

Everything else looks good, but QueryFreqList and QueryExtraList still have the Clone button:
Screenshot 2024-05-16 at 12 27 36 PM

@CarolineDenis
Copy link
Contributor Author

@lexiclevenger, sorry those 2 should not have been a part of the list.
Updated it

@CarolineDenis CarolineDenis requested review from lexiclevenger and a team May 16, 2024 17:35
lexiclevenger
lexiclevenger approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@lexiclevenger lexiclevenger left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Go to app resource

  • Click on any resource with a visual editor (e.g. web links)

  • Verify that there is no clone option for:

  • TypeSearches

  • WebLinks

  • DataObjFormatters

  • UIFormatters

  • DataEntryTaskInit

  • InteractionsTaskInit

  • UserPreferences

  • CollectionPreferences

  • ExpressSearchConfig

  • leaflet-layers

The clone button has been removed from everything on the list now. 👍

@Areyes42 Areyes42 self-requested a review May 16, 2024 19:55
Areyes42
Areyes42 approved these changes May 16, 2024
View reviewed changes
Copy link

@Areyes42 Areyes42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Go to app resource

  • Click on any resource with a visual editor (e.g. web links)

  • Verify that there is no clone option for:

  • TypeSearches

  • WebLinks

  • DataObjFormatters

  • UIFormatters

  • DataEntryTaskInit

  • InteractionsTaskInit

  • UserPreferences

  • CollectionPreferences

  • ExpressSearchConfig

  • leaflet-layers

Looks good! Clone button is no longer present for the listed resources.

@Areyes42 Areyes42 requested a review from a team May 16, 2024 20:01
@CarolineDenis CarolineDenis removed the request for review from a team May 17, 2024 18:35
@CarolineDenis @github-actions
Lint code with ESLint and Prettier
720a304 
Triggered by dd4cbec on branch refs/heads/issue-4809
maxpatiiuk
maxpatiiuk approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@CarolineDenis CarolineDenis merged commit fe30ca8 into production May 21, 2024
9 checks passed
@CarolineDenis CarolineDenis deleted the issue-4809 branch May 21, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpatiiuk maxpatiiuk maxpatiiuk approved these changes

@Areyes42 Areyes42 Areyes42 approved these changes

@lexiclevenger lexiclevenger lexiclevenger approved these changes

@melton-jason melton-jason Awaiting requested review from melton-jason

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: ✅Done
Milestone
7.9.6
Development

Successfully merging this pull request may close these issues.

Cloning an app resource with a visual editor does not clone the visual editor part
4 participants
@CarolineDenis @maxpatiiuk @Areyes42 @lexiclevenger