Prevent user from saving CO without current determination #4901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Triggered by c560078 on branch refs/heads/issue-4819
This reverts commit bb4470c.
maxpatiiuk
approved these changes
May 30, 2024
specifyweb/frontend/js_src/lib/components/DataModel/businessRuleDefs.ts
Outdated
Show resolved
Hide resolved
melton-jason
approved these changes
May 31, 2024
There was a problem hiding this comment.
This approach is fine for now given how businessRules and saveBlockers are currently implemented 😅
Still is a mess with how verbose and complicated it is to add 'simple' behavior such as this.
Thus most of these comments are just related to refactoring and nothing functional.
specifyweb/frontend/js_src/lib/components/DataModel/businessRuleDefs.ts
Outdated
Show resolved
Hide resolved
specifyweb/frontend/js_src/lib/components/DataModel/businessRuleDefs.ts
Outdated
Show resolved
Hide resolved
specifyweb/frontend/js_src/lib/components/DataModel/businessRuleDefs.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Jason Melton <64045831+melton-jason@users.noreply.github.com>
- uses onAdded instead - setting isCurrent to true in onAdded triggers the isCurrent fieldCheck which unchecks other determinations
melton-jason
approved these changes
May 31, 2024
Areyes42
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Testing instructions
- Go to Data Entry->Collection Object
- Add multiple determinations
- Play around with deleting, unchecking and adding a current determination
- Verify save is blocked when no current determinations exist
- Verify save is enabled when a current determination is added
Looks good!
combs-a
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
- Go to Data Entry->Collection Object
- Add multiple determinations
- Play around with deleting, unchecking and adding a current determination
- Verify save is blocked when no current determinations exist
- Verify save is enabled when a current determination is added
Looks good! Worked with unchecking and deleting, as well as newly added determinations. No unexpected behavior during my checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4819
Checklist
and self-explanatory (or properly documented)
Testing instructions