-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable save and delete buttons in QCBX overlay in app resources #4891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
take a look at how FormMeta displays different dialog based on whether it's in the form editor or not, and do something similar here, rather than URL parsing
@maxpatiiuk , |
I should clarified that I meant look at how that place detects if it's in the form meta and do something similar to detect if you are in the form editor in here rather than URL parsing see #4891 (comment) |
Triggered by e1cb827 on branch refs/heads/issue-4886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean!
Currently, you can also delete resources through the form editor.
Is this also something we want to disable?
|
@CarolineDenis I think so! |
Triggered by c40a326 on branch refs/heads/issue-4886
Previewing record formatters using existing records also allows the user to edit and save those records, as well as create and delete records using the query combo boxes. Is that also something that should be addressed in this PR? |
@lexiclevenger, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Go to app resources -> form definition
- Click on any table with a query combo box in the form (e.g. collection object with the accession qcbx)
- In visual editor click the add button for the query combo box
- Fill out some information in the form
- verify save button is disabled
- verify there is no delete button
Can't save or delete, as expected!
Fixes #4886
Checklist
and self-explanatory (or properly documented)
Testing instructions